Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: disable sphinx-hoverxref in our docs #11762

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Nov 12, 2024

We are going to start using the new addon link previews.


📚 Documentation previews 📚

We are going to start using the new addon link previews.
@humitos humitos requested review from a team as code owners November 12, 2024 17:23
@humitos humitos requested a review from ericholscher November 12, 2024 17:23
@ericholscher ericholscher merged commit 404d82a into main Nov 12, 2024
4 of 6 checks passed
@ericholscher ericholscher deleted the humitos/disable-hoverxref branch November 12, 2024 17:31
@humitos
Copy link
Member Author

humitos commented Nov 12, 2024

He, the list from file tree diff is pretty long and useless 🙃

@ericholscher
Copy link
Member

@humitos Yea, I think it likely needs to be up to date with main to get the "real" changes. I know there was some discussion about this previously about the PR builds and which base branch to compare them to in some other contexts.

@humitos
Copy link
Member Author

humitos commented Nov 12, 2024

I suppose we eventually could let the user change the base branch from the addons UI if needed, and the notificación could be updated dynamically with the files

@humitos
Copy link
Member Author

humitos commented Nov 12, 2024

Actually, thinking more about the API filed names now that you mentioned "base branch". current version and base version are a lot better names and are also standards in the GitHub / Git / diffing world. It probably makes sense to use those cc @ericholscher

@ericholscher
Copy link
Member

@humitos that is probably a reasonable naming convention as well. I just didn't want to invent a new one.

humitos added a commit that referenced this pull request Nov 13, 2024
Instead of using `version_a` and `version_b`, we are using `current` and `base`
for these field names. These names are standard GitHub/Git names, for example
when creating pull requests and you have to select the "base branch".

* Refs: #11762 (comment)
* Refs: #11749 (comment)
humitos added a commit that referenced this pull request Nov 18, 2024
Instead of using `version_a` and `version_b`, we are using `current` and
`base` for these field names. These names are standard GitHub/Git names,
for example when creating pull requests and you have to select the "base
branch".

* Refs:
#11762 (comment)
* Refs:
#11749 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants